Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed serverinfo menu item permissions and cleanup translations #157

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

vmalyk
Copy link
Contributor

@vmalyk vmalyk commented Apr 8, 2024

Hi,

As I see "Server Info" item (LInfo Integration) has been removed since Pimcore 10 : https://pimcore.com/docs/pimcore/10.6/Development_Documentation/Installation_and_Upgrade/Upgrade_Notes/index.html#page_10-0-0. And in latest versions of Perspecitve bundle it's obsolete.

In PR implemented:

  • Removed menu item permission
  • Clean up translations

Please review,

@vmalyk vmalyk changed the base branch from 1.x to 1.7 April 8, 2024 08:00
@robertSt7 robertSt7 self-assigned this May 24, 2024
@robertSt7
Copy link
Contributor

Since we are using POEditor for the translations it's only necessary to remove the key in admin.en.yml. Could you please remove the modifications of the other files? Thanks

…_items_serverinfo in all translations excluding English.
@vmalyk
Copy link
Contributor Author

vmalyk commented May 24, 2024

@robertSt7 , it's done as requested.

@robertSt7 robertSt7 added this to the 1.7.2 milestone Jun 7, 2024
@robertSt7 robertSt7 merged commit 09d0292 into pimcore:1.7 Jun 7, 2024
6 checks passed
@robertSt7
Copy link
Contributor

@vmalyk Thanks a lot for the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants